Skip to content

HotFix for Python 3.11 #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 15, 2023
Merged

HotFix for Python 3.11 #348

merged 12 commits into from
Apr 15, 2023

Conversation

MateusStano
Copy link
Member

Pull request type

  • Lint (black rocketpy) has passed locally and any fixes were made
  • All tests (pytest --runslow) have passed locally

What is the current behavior?

RocketPy can not be installed with Python 3.11. This is due to the netCDF4 lib version requirement being limited to >=1.4, 1.6<=

What is the new behavior?

The netCDF4 library has been updated to >=1.6.2

Does this introduce a breaking change?

  • Yes
  • No

@github-actions github-actions bot requested a review from Gui-FernandesBR April 6, 2023 14:42
@giovaniceotto
Copy link
Member

I'll check if this works in Google Colab before approving, due to this: Unidata/netcdf4-python#1179

@giovaniceotto
Copy link
Member

Still not working in Windows. At least, the Windows test is not passing, due to an hdf5 error raised when trying to install netCDF4.

@giovaniceotto
Copy link
Member

giovaniceotto commented Apr 10, 2023 •
edited
Loading

Here is what I have done:

  • Fixed support for Python 3.7
  • Bumped up version to 0.13.1

Here what still needs to be done:

  • Find a solution that works in Google Colab

@giovaniceotto
Copy link
Member

giovaniceotto commented Apr 10, 2023 •
edited
Loading

Good news:

  • Found a solution that works for Google Colab in 3c6f115

Bad news:

  • Google Colab's problem seems to also happen in Codespaces.

I wonder if the issue with netCDF4 version (Unidata/netcdf4-python#1179) happens in any linux installation. @phmbressan, can you help us out here?

All that needs to be done is: install this version of RocketPy in a linux system, as is, and try to run pytest --runslow -v. If the slow environment test fails, we may need to replace the "colab" criteria to a "linux" criteria.

@giovaniceotto giovaniceotto linked an issue Apr 10, 2023 that may be closed by this pull request
BUG: Unable to setup RocketPy using python 3.11 #265
Closed
Gui-FernandesBR
Gui-FernandesBR reviewed Apr 14, 2023
View reviewed changes
docs/user/requirements.rst
@@ -21,18 +20,19 @@ The following packages are needed in order to run RocketPy:
- Numpy >= 1.0
- Scipy >= 1.0
- Matplotlib >= 3.0
- netCDF4 >= 1.4
- netCDF4 >= 1.4, < 1.6 for Python 3.7+, netCDF4 >= 1.6.2 for Python 3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this code line already working properly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is documentation. It shouldnbe working. Are you getting errors when building the docs?

@MateusStano MateusStano merged commit abcbdcb into master Apr 15, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the hotfix-python311 branch May 26, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gui-FernandesBR Gui-FernandesBR Gui-FernandesBR left review comments

@giovaniceotto giovaniceotto giovaniceotto approved these changes

Assignees

@MateusStano MateusStano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Unable to setup RocketPy using python 3.11
4 participants
@MateusStano @giovaniceotto @Gui-FernandesBR @lint-action